tryphotino / photino.Native

https://tryphotino.io
Apache License 2.0
138 stars 47 forks source link

Support musl libc? #98

Open a-n-t-i-b-a-r-y-o-n opened 1 year ago

a-n-t-i-b-a-r-y-o-n commented 1 year ago

Hi there! Love the project - been tinkering with it for hobby stuff and I'm very thankful that it exists.

Problem

Current Linux releases only support GNU libc

Suggested Change

Add support for musl libc

Background

In my (admittedly limited) testing, it appears this project builds and runs fine on Alpine Linux, which uses musl libc. The existing Photino.Native Linux releases, however, result in segfault hell on musl libc systems.

Deconstructing the Photino.Native NuGet package indicates that the following runtimes are currently supported:

These days, .NET makes the distinction in its runtime identifiers between "linux-x64" and "linux-musl-x64".

Open Question

Is the project open to supporting this runtime? AFAIUI, this might incur additional costs in terms of Azure resources & build minutes.

I'll gladly open a PR to make the required makefile and pipeline changes if this is something the project is open to supporting.

Didn't see anything here with "musl" in it, so figured I'd ask around before spending time making this change.

MikeYeager commented 1 year ago

@g-r-a-v-i-t-y-w-a-v-e This hasn't been on our radar. Thanks for bringing this up. We'd be happy to have some help with this. We do all of our testing on Ubuntu. If you do a pull request, please target the debug branch, not master. Thank you.