search

tryretool / react-retool

MIT License
39 stars 14 forks source link

[feat] Add iframe permissions #45

Closed zhanlarr closed 1 year ago

zhanlarr commented 1 year ago

Hm I'm realizing that this is probably much more complicated than it needs to be - we should probably just allow users to pass through the allow and sandbox properties, with a warning when the sandbox property doesn't include allow-scripts and allow-same-origin

zhanlarr commented 1 year ago

@kentwalters @BenjamynBaker I actually ended up just setting this up to always include allow-scripts and allow-same-origin whenever sandbox is specified. I'll also update the README here

kentwalters commented 1 year ago

LGTM! We'll let @BenjamynBaker stamp, then all good to merge.

BenjamynBaker commented 1 year ago

LGTM