search

tryretool / retool-helm

MIT License
45 stars 57 forks source link

Add startupProbe to backend deployment #103

Closed eltioemil closed 1 year ago

eltioemil commented 1 year ago

Following this conversation, it would be good to have startupProbe configuration on the backend deployment to avoid increasing initialDelaySeconds on the livenessProbe too much, that will defeat the purpose of livenessProbes. Following the recommended practice from kubernetes for slow starting containers.

jjlgao commented 1 year ago

👋 hi Emilio! Apologies for the late action here. We noticed this PR a little late, and since you had merge conflicts, I opened new PRs and got the changes in for you: https://github.com/tryretool/retool-helm/pull/109

It's been released as v5.0.7 here, and as v4.11.19 on our Workflows-enabled helm chart. Thanks for making the change!

eltioemil commented 1 year ago

No worries, thank you so much!