tryretool / retool-helm

MIT License
45 stars 57 forks source link

Usage of deprecated external secrets manager #107

Open brunoluiz opened 1 year ago

brunoluiz commented 1 year ago

Currently this helm chart is enabling users to use external secrets through two means. The externalSecretsOperator though is using a deprecated external secret api, available through https://github.com/external-secrets/kubernetes-external-secrets.

The new project is now https://github.com/external-secrets/external-secrets, which comes under the api external-secrets.io/v1beta1.

My question is:

  1. Should this project consider the new external-secrets apis?
  2. If so, how would you keep up with new api releases or changes?
brunoluiz commented 1 year ago

The way I sorted in the project I am working on is by:

a. Declaring the external secret referencing outside of the helm chart b. Passing the key reference using

    externalSecrets:
      enabled: true
      name: retool-default

Not sure what the plans for the OP questions, but keeping up with external CRDs can always become tricky.