tryretool / retool-helm

MIT License
45 stars 57 forks source link

add new internal worker + worker/temporal validations #129

Open avimoondra opened 10 months ago

avimoondra commented 10 months ago

workflows worker on based on version, internal worker off. ✅

$ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set internalWorker.enabled=false | grep "worker"
# Source: retool/templates/deployment_workflows_worker.yaml
  name: foo-retool-workflow-worker
    retoolService: foo-retool-workflow-worker
# Source: retool/templates/deployment_workflows_worker.yaml
  name: foo-retool-workflow-worker
    retoolService: foo-retool-workflow-worker
      retoolService: foo-retool-workflow-worker
        prometheus.io/job: foo-retool-workflow-worker
        retoolService: foo-retool-workflow-worker

workflows worker on version, internalWorker on ✅

$ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set internalWorker.enabled=true | grep "worker"
# Source: retool/templates/deployment_internal_worker.yaml
  name: foo-retool-internal-worker
    retoolService: foo-retool-internal-worker
# Source: retool/templates/deployment_workflows_worker.yaml
  name: foo-retool-workflow-worker
    retoolService: foo-retool-workflow-worker
# Source: retool/templates/deployment_internal_worker.yaml
  name: foo-retool-internal-worker
    retoolService: foo-retool-internal-worker
      retoolService: foo-retool-internal-worker
        prometheus.io/job: foo-retool-internal-worker
        retoolService: foo-retool-internal-worker
# Source: retool/templates/deployment_workflows_worker.yaml
  name: foo-retool-workflow-worker
    retoolService: foo-retool-workflow-worker
      retoolService: foo-retool-workflow-worker
        prometheus.io/job: foo-retool-workflow-worker
        retoolService: foo-retool-workflow-worker

workflows worker off based on version, internalWorker on -- validation error! ❌

➜  $ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="2.6.10" --set internalWorker.enabled=true | grep "worker"
Error: execution error at (retool/templates/NOTES.txt:34:4):
VALUES VALIDATION:
internalWorker:
  Internal worker is enabled (via internalWorker.enabled), but Temporal is not enabled via retool-temporal-services-helm.enabled or workflows.temporal.enabled or via Retool's Managed Temporal for Retool Workflows (via workflows.enabled explicitly, or workflows.enabled implicitly based on image.tag > 3.6.11)

Use --debug flag to render out invalid YAML

workflows worker off based on version, internalWorker on + temporal configured ✅

➜  $ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="2.6.10" --set internalWorker.enabled=true --set workflows.temporal.enabled=true | grep "worker"
# Source: retool/templates/deployment_internal_worker.yaml
  name: foo-retool-internal-worker
    retoolService: foo-retool-internal-worker
# Source: retool/templates/deployment_internal_worker.yaml
  name: foo-retool-internal-worker
    retoolService: foo-retool-internal-worker
      retoolService: foo-retool-internal-worker
        prometheus.io/job: foo-retool-internal-worker
        retoolService: foo-retool-internal-worker
Ayoakala commented 6 months ago

will take this on