Closed avimoondra closed 6 months ago
cc @ryanartecona @KnlnKS (thanks for the discussion and review!)
Before
Changed values
diff --git a/helm/internal-tools/internal-onprem/onprem-instances/values.avi-test.retool.dev.yaml b/helm/internal-tools/internal-onprem/onprem-instances/values.avi-test.retool.dev.yaml
index 22eb17ab98..285a4af396 100644
--- a/helm/internal-tools/internal-onprem/onprem-instances/values.avi-test.retool.dev.yaml
+++ b/helm/internal-tools/internal-onprem/onprem-instances/values.avi-test.retool.dev.yaml
@@ -5,12 +5,25 @@ image:
tag: "3.24.14"
pullPolicy: "Always"
+backend:
+ name: backend-avi
+
+replicaCount: 2
+
+jobsRunner:
+ name: jobs-runner-avi
+
workflows:
enabled: true
temporal:
enabled: false
+ backend:
+ name: workflow-backend-avi
+ worker:
+ name: workflow-temporal-worker-avi
codeExecutor:
+ name: code-executor-avi
enabled: true
image:
tag: "3.24.14"
Ran command
helm upgrade --install -f ~/retool-k8s/helm/internal-tools/internal-onprem/onprem-instances/values.base.yaml -f ~/retool-k8s/helm/internal-tools/internal-onprem/onprem-instances/values.avi-test.retool.dev.yaml avi-test ~/retool-helm/charts/retool
After
- name: JWT_SECRET
valueFrom:
secretKeyRef:
{{- if .Values.config.jwtSecretSecretName }}
name: {{ .Values.config.jwtSecretSecretName }}
key: {{ .Values.config.jwtSecretSecretKey | default "jwt-secret" }}
{{- else }}
name: {{ template "retool.backend.name" . }}
key: jwt-secret
{{- end }}
So I've removed those changes to secret locations (https://github.com/tryretool/retool-helm/pull/143/commits/b37160e9a491f51f704a0bb0aaafc0b8d044b556), and we're all good:
Enable internal Retool to align service names with Cloud Prod, for DD dashboards shared across env
before the change
without custom names:
after the change
without custom names (no difference):
with custom names: