We are able to use version: 5.0.10 in our Istio cluster, but not 6.0.13 because the chart renders things that do not pass our Istio checks.
Error: 3 errors occurred:
* Service/my-retool/my-retool-workflow-backend: service "my-retool-workflow-backend/my-retool/:" has an unnamed port. This is not recommended, See https://istio.io/v1.19/docs/ops/deployment/requirements/
* Service/my-retool/my-retool-workflow-worker: service "my-retool-workflow-worker/my-retool/:" port "retool" does not follow the Istio naming convention. See https://istio.io/v1.19/docs/ops/deployment/requirements/
* Service/my-retool/my-retool-workflow-worker: service "my-retool-workflow-worker/my-retool/:" port "metrics" does not follow the Istio naming convention. See https://istio.io/v1.19/docs/ops/deployment/requirements/
Hello,
We are able to use version: 5.0.10 in our Istio cluster, but not 6.0.13 because the chart renders things that do not pass our Istio checks.
Error 1
port is not named - issue here: https://github.com/tryretool/retool-helm/blob/main/charts/retool/templates/deployment_workflows.yaml#L310
Possible fix: Can a configurable port name be added?
The render:
Error 2 and 3
port names are unable to follow convention
https://github.com/tryretool/retool-helm/blob/main/charts/retool/templates/deployment_workflows_worker.yaml#L234-L239
Possible fix: Can these port names be configurable?
The render:
My proposed fixes above should not be breaking changes.
Thanks