Closed avimoondra closed 3 months ago
LGTM
LGTM, the defaulting comments are not necessary but I think you could collapse the conditionals down
LGTM, the defaulting comments are not necessary but I think you could collapse the conditionals down
The if/else is giving that default - but I ran into an issue using default with "template"... e.g. this wasn't working:
{{ .Values.codeExecutor.portName | default (template "retool.name" .) }}
neither this
{{ default .Values.codeExecutor.portName (template "retool.name" .) }}
lmk if you have a different suggestion @alexlo03 ! thanks for review.
I ran into an issue using default with "template"...
oh I didn't notice this comment before, but that's because template
doesn't return the value, it just prints it out to the output. you can just change template
to include
, which returns instead of printing, and then it will work as expected with the default pipeline. usually include is preferred over template in helm for exactly this reason.
I ran into an issue using default with "template"...
oh I didn't notice this comment before, but that's because
template
doesn't return the value, it just prints it out to the output. you can just changetemplate
toinclude
, which returns instead of printing, and then it will work as expected with the default pipeline. usually include is preferred over template in helm for exactly this reason.
Ah thanks @ryanartecona - will address all of it w/your feedback today! 🙏
gentle ping. would like to see this in before we upgrade charts. thanks 🙏
Closing in favor of https://github.com/tryretool/retool-helm/pull/170
Addresses https://github.com/tryretool/retool-helm/issues/144, alternate to https://github.com/tryretool/retool-helm/pull/151
Addresses: https://github.com/tryretool/retool-helm/issues/155, alternate to https://github.com/tryretool/retool-helm/pull/156
(also fixes https://github.com/tryretool/retool-helm/issues/155)