search

tryretool / retool-helm

MIT License
45 stars 57 forks source link

Code executor does not expose metrics endpoint but does have metrics annotations #155

Closed erulabs closed 3 months ago

erulabs commented 5 months ago

The retool-code-executor deployment contains the prometheus scrape annotations:

    prometheus.io/scrape: 'true'
    prometheus.io/port: '9090'

However, there is no process listening on 9090 in code executor:

root@retool-code-executor-8578784858-w9m2f:/retool/code_executor# curl localhost:9090
curl: (7) Failed to connect to localhost port 9090: Connection refused
root@retool-code-executor-8578784858-w9m2f:/retool/code_executor# netstat -pnlt
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp6       0      0 :::3004                 :::*                    LISTEN      14/node

We should remove the prometheus scrape annotations from code executor.