Remove prom scrape annotations from code-executor, which does not have metrics

tryretool / retool-helm

MIT License

45 stars 57 forks source link

Remove prom scrape annotations from code-executor, which does not have metrics #156

Closed erulabs closed 5 months ago

erulabs commented 5 months ago

This prevents error-spam from failures to scrape metrics.

Resolves #155

samsternatretool commented 5 months ago

@erulabs thank you for submitting this PR! Let me find the right person to review it.

ryanartecona commented 5 months ago

ah yes, good find. this happened to be noticed independently and will be fixed (in the same way as here) in #154, which should be the next release to go out, soon. cc @avimoondra

avimoondra commented 5 months ago

ah yes, good find. this happened to be noticed independently and will be fixed (in the same way as here) in #154, which should be the next release to go out, soon. cc @avimoondra

🎯 should be resolved in a day or two!

samsternatretool commented 5 months ago

Sounds like we can close this one, thanks @erulabs for the contribution though!