search

tryretool / retool-helm

MIT License
45 stars 57 forks source link

update port names for Services for istio compliance #170

Closed avimoondra closed 3 months ago

avimoondra commented 3 months ago

Addresses https://github.com/tryretool/retool-helm/issues/144, alternate to https://github.com/tryretool/retool-helm/pull/151

Addresses: https://github.com/tryretool/retool-helm/issues/155, alternate to https://github.com/tryretool/retool-helm/pull/156

Lighter weight approach than https://github.com/tryretool/retool-helm/pull/154

https://istio.io/v1.0/docs/setup/kubernetes/spec-requirements/

Named ports: Service ports must be named. The port names must be of the form [-] with http, http2, grpc, mongo, or redis as the in order to take advantage of Istio's routing features. For example, name: http2-foo or name: http are valid port names, but name: http2foo is not. If the port name does not begin with a recognized prefix or if the port is unnamed, traffic on the port will be treated as plain TCP traffic (unless the port explicitly uses Protocol: UDP to signify a UDP port).

https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/, could also use appProtocol if prefix in names is not desirable.

Tested in internal (balloon) instances.

(also fixes https://github.com/tryretool/retool-helm/issues/155)

avimoondra commented 3 months ago

@alexlo03 Re-visiting this, I think it should work istio compliance requirements?