ingress semVerCompare logic does not work for eks

45cali commented 2 years ago

https://github.com/tryretool/retool-helm/blob/main/templates/ingress.yaml#L5-L11

eks adds -eks-<some more stuff> to the version of eks

 k version                                                                                                                                                                                                                                     <aws:pii-dev-/devops_team>
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.0", GitCommit:"af46c47ce925f4c4ad5cc8d1fca46c7b77d13b38", GitTreeState:"clean", BuildDate:"2020-12-08T17:59:43Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.16-eks-25803e", GitCommit:"25803e8d008d5fa99b8a35a77d99b705722c0c8c", GitTreeState:"clean", BuildDate:"2022-02-16T23:37:16Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

so we end up with apiVersion: extensions/v1beta1 instead of networking.k8s.io/v1 for our ingress apiVersion

45cali commented 2 years ago

also just found out this prevents us from setting ingress class name too

https://github.com/tryretool/retool-helm/blob/657d8a131e7961d52fe4580cc66099bacd20f097/templates/ingress.yaml#L25-L26

asaf400 commented 1 year ago

I've created a PR to fix this: #94

tryretool / retool-helm

ingress semVerCompare logic does not work for eks #56