search

tryretool / retool-helm

MIT License
45 stars 57 forks source link

Support EKS #94

Closed asaf400 closed 7 months ago

asaf400 commented 1 year ago

use .Capabilities.KubeVersion.Version instead of .Capabilities.KubeVersion.GitVersion in order to support EKS flavored k8s cluster.

Tested all conditions locally via:

helm template ./  --version 5.0.3 --namespace retool --set config.encryptionKey="abc" --set image.tag=2.110.3 --kube-version "v1.13.16-eks-48e63afoobar"
helm template ./  --version 5.0.3 --namespace retool --set config.encryptionKey="abc" --set image.tag=2.110.3 --kube-version "v1.15.16-eks-48e63afoobar"
helm template ./  --version 5.0.3 --namespace retool --set config.encryptionKey="abc" --set image.tag=2.110.3 --kube-version "v1.19.16-eks-48e63afoobar"

and successfully deployed on EKS 1.23 using packaged helm chart (via flux) from my main branch (modified for auto-release via github actions) https://asaf400.github.io/retool-helm/index.yaml https://github.com/asaf400/retool-helm

ryanartecona commented 1 year ago

Thanks! Looks straightforward enough, and it will be good to move away from undocumented helm behavior.

What's the helm version of your helm?

asaf400 commented 1 year ago

version.BuildInfo{Version:"v3.12.1", GitCommit:"f32a527a060157990e2aa86bf45010dfb3cc8b8d", GitTreeState:"clean", GoVersion:"go1.20.4"}

asaf400 commented 7 months ago

Fixed as part of #118 ✅