search

tryretool / terraform-retool-modules

MIT License
23 stars 40 forks source link

AWS ECS - propagate tags to tasks #39

Closed alexmaras closed 8 months ago

alexmaras commented 9 months ago

In the AWS ECS setup, the aws_ecs_service resource doesn't propagate tags to the tasks. This results in large amounts of fargate VCPU usage going untagged and potentially not visible in AWS Cost Explorer.

Could we get this added as per the AWS terraform documentation documentation on the service resource. There are two options, so perhaps defaulting to one and allowing a variable for the other would make sense.

samsternatretool commented 8 months ago

@alexmaras thanks for the feedback, we'll take a look. If you know how this should be solved and feel comfortable submitting a PR we will definitely try to get it merged!

alexmaras commented 8 months ago

@samsternatretool - https://github.com/tryretool/terraform-retool-modules/pull/40

Forgot to link across to this when I put it up.

samsternatretool commented 8 months ago

Fixed by https://github.com/tryretool/terraform-retool-modules/pull/40

Thank you @alexmaras for contributing!