Closed chuck-flowers closed 3 years ago
@tryton-vanmeer do you have any thoughts or feedback on these code changes?
My bad, missed the PR.
I'll make sure to take a look today and hopefully have a new release out.
No problem. I might open some additional PRs in the future as well. I really like the extension you made and basically just want to add the same functionality to more pages on Steam's site without having to click each game individually.
I tested your branch. Just a couple nitpicks.
When the rating is loaded with "Awaiting reports", it never links to the ProtonDB page.
And games that should have a "Native" rating are never assigned.
Otherwise looks good! With those couple fixes, I can merge and make a new release.
@tryton-vanmeer thanks for the feedback. I just pushed a commit containing your recommended changes
Changes:
Tested on:
Additonal Notes
I don't have a ton of experience with open-source contributions so please feel free to offer any feedback and guidance and I will happily make corrections. I've never done extension development and I do very limited JavaScript development so if I'm doing something that's not idiomatic for the paradigm/language, I'd like to hear feedback for that as well.
I know there's still some code duplication but I didn't want to make any major code organization changes without consulting with the owner of the repository first.