Changes the variable type of the the wish list row for loop from var to const
Tested on:
Browser
Tested
Version
Working
Firefox
Yes
85
Yes
Chrome
No
?
?
Additional Notes
I noticed an intermittent issue where the incorrect ratings were being assigned to rows in the wish list. I believe this was caused by the outer scope of the for loop mutating the row variable which was visible to the inner scope of the ProtonDB callback. The issue was intermittent but after testing several times I was unable to reproduce the issue with this change.
If you have more experience with JavaScript perhaps you could comment and let me know if my hypothesis is correct. Sorry for having to push a bug fix so quickly after the new version of the extension was published.
soredake
commented
3 years ago
Changes:
vartoconstTested on:
Additional Notes
I noticed an intermittent issue where the incorrect ratings were being assigned to rows in the wish list. I believe this was caused by the outer scope of the for loop mutating the row variable which was visible to the inner scope of the ProtonDB callback. The issue was intermittent but after testing several times I was unable to reproduce the issue with this change.
If you have more experience with JavaScript perhaps you could comment and let me know if my hypothesis is correct. Sorry for having to push a bug fix so quickly after the new version of the extension was published.