search

trytriplex / triplex

The visual IDE for the web.
https://triplex.dev
GNU General Public License v3.0
818 stars 28 forks source link

The esbuild dependency has all platforms available in the macOS distributable #138

Open dceddia opened 1 year ago

dceddia commented 1 year ago

First off I just wanted to say this is an amazing project. Excellent work! It's a ton of fun to play around with.

I'm always curious about what's inside native apps so I almost reflexively clicked into Show Package Contents on Triplex.app. It's pretty common for Frameworks to be big because of Electron, but Resources was big too, and I noticed all of it is in node_modules (seems reasonable), and then most of that is in @esbuild – 175mb worth!

I'm not sure what step of the Electron build process this would go in, but it seems like this folder could be pruned (almost?) entirely and save a bunch of space in the download. It seems it shouldn't need those binaries during runtime, and there might be other folders that could be pruned too (esbuild, vite, and rollup probably?).

CleanShot 2023-10-02 at 11 30 16@2x
itsdouges commented 1 year ago

Thank you! Yeah we definitely don't need to be including all the platform esbuild packages, hey! Good catch. Will update this issue to be both resolving this + adding ASAR archiving.