search

trzecieu / emscripten-docker

Docker image with Emscripten to compile ASM.js and WebAssembly
MIT License
97 stars 29 forks source link

Upgrade to CMake 3.14.3 #43

Closed forderud closed 5 years ago

forderud commented 5 years ago

Fixes https://github.com/trzecieu/emscripten-docker/issues/42.

I noticed that https://github.com/trzecieu/emscripten-docker/blob/master/docker/trzeci/emscripten-slim/Dockerfile seem to contain an older 3.6 version of CMake. I didn't touch this file, since it does not appear to be synced to https://github.com/trzecieu/emscripten-docker/blob/master/docker/trzeci/emscripten/Dockerfile

trzecieu commented 5 years ago

Sure, looks great! I'll rebuild latest pushed tag also.

trzecieu commented 5 years ago

Done :)

➜ docker run --rm trzeci/emscripten:sdk-tag-1.38.31-64bit cmake --version 
cmake version 3.14.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

Thank you so much for your contribution!

// Indeed, there is a cmake in emscripten-sclim image, but it's just a temporary solution for sdk compilation.

forderud commented 5 years ago

Thanks a lot for updating the dockerhub image so quickly 👍