search

trzecieu / emscripten-docker

Docker image with Emscripten to compile ASM.js and WebAssembly
MIT License
97 stars 29 forks source link

Update to the latest Emscripten #46

Closed VirtualTim closed 5 years ago

VirtualTim commented 5 years ago

Currently the latest tag is sdk-tag-1.38.32-64bit. Emscripten is up to 1.38.42.

Is there any plan to update this image for the latest Emscripten?

trzecieu commented 5 years ago

Hi @VirtualTim, Thank you for this report, I'm aware about issue and will work to fix it.
Due vacation I will handle this in ~2w. Cheers!

VirtualTim commented 5 years ago

No worries. I appreciate the ETA.

boardend commented 5 years ago

Is #45 blocking the update to the latest version? (1.38.41)

Let me know if I can help with investigation or testing.

trzecieu commented 5 years ago

Hi @boardend indeed, those two issues are the same. Due personal reasons my time is very limited. Nonetheless, I'm dedicated in the remaining fraction of time to fix entire docker image pipeline. Thank you for your offer.

VirtualTim commented 5 years ago

So how's the progress going on this? Anything I can do to help?

trzecieu commented 5 years ago

Hi, @VirtualTim I have a working solution with fastcomp compiler, I have one element which is too hacky to be published, as it points on some arbitrary version of binaryen, once this is solved it will be done.

trzecieu commented 5 years ago

Hi, I fixed all related problems, sorry that it took so long, it was a nice puzzle to solve. At the moment I've started to rebuild all images 1.38.34 upwards. Will take a couple of hours until they land in registry, At the moment you can check 1.38.40 as I was using it as a test case. 

➜ docker run --rm -it trzeci/emscripten:sdk-tag-1.38.40-64bit emcc --version
Unable to find image 'trzeci/emscripten:sdk-tag-1.38.40-64bit' locally
sdk-tag-1.38.40-64bit: Pulling from trzeci/emscripten
9fc222b64b0a: ...
Digest: sha256:839c186ec629fcec7ebb5ad50b9a503415707d98cbdaa5afaf4d7e15555f1e7b
Status: Downloaded newer image for trzeci/emscripten:sdk-tag-1.38.40-64bit
emcc (Emscripten gcc/clang-like replacement) 1.38.40 ((unknown revision))
Copyright (C) 2014 the Emscripten authors (see AUTHORS.txt)
This is free and open source software under the MIT license.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Will keep this issue open for a couple of days to make sure everything works for you. Cheers,

VirtualTim commented 5 years ago

Awesome. Thanks Piotr. I should get a chance to test these out Monday.

trzecieu commented 5 years ago

Should be done, please re-open in case of any problems, Cheers!

VirtualTim commented 5 years ago

I switched over my builds to use 1.38.43 on Monday, and it all seems good.