search

trzecieu / emscripten-docker

Docker image with Emscripten to compile ASM.js and WebAssembly
MIT License
97 stars 29 forks source link

Upgrade to CMake 3.18.3 (latest version) #72

Closed forderud closed 3 years ago

forderud commented 3 years ago

Done to enable building of CMake projects requiring CMake 3.16 or newer due to usage of target_precompile_headers (or other feature) introduced since 3.14. CMake 3.18.3 seem to be the latest available version on https://cmake.org/download/ so I propose to just upgrade to the latest version.

REF: https://cmake.org/cmake/help/git-master/command/target_precompile_headers.html

forderud commented 3 years ago

@trzecieu Would it be possible for you to consider this proposal?

The reason for requesting a CMake upgrade is that one of the projects I want to build have just upgraded to CMake 3.16. This breaks the build unless my "emscripten-docker"-based WASM toolchain is also upgraded.

forderud commented 3 years ago

Gentle reminder.

forderud commented 3 years ago

Gentle reminder.

forderud commented 3 years ago

Gentle reminder.

forderud commented 3 years ago

Gentle reminder.

kripken commented 3 years ago

Looks like @trzecieu may not be available to review this? I don't think anyone else has write permission to this repo, so that may be an issue. Sorry for the delay @forderud

@sbc100 I know we have https://github.com/emscripten-core/emscripten-ci for the Docker image in our CI. Have we considered adding this general-purpose docker image to emscripten-core as well? That sounds familiar but I'm not sure where we ended up.

sbc100 commented 3 years ago

I believe the docker image here has been replaced by the emsdk docker image: https://github.com/emscripten-core/emsdk/tree/master/docker

This image is based on debian/buster and is available at: https://hub.docker.com/r/emscripten/emsdk

If that image doesnt have a cmake version new enough please re-file this bug at https://github.com/emscripten-core/emsdk.

trzecieu commented 3 years ago

My apologies for not reacting on this issue before. I believe that my build server was pulled down while I was unavailable, so that my images are out of date. I believe that https://hub.docker.com/r/emscripten/emsdk is more up to date at the moment.

I will try to bump current images as something complementary to the official images from Emscripten.

One more time, my apologies.

forderud commented 3 years ago

Thanks for the tip @kripken @sbc100 @trzecieu 👍 I'm now transitioning over to using the official Emscripten docker images.