search

ts-factory / bublik-ui

Apache License 2.0
0 stars 1 forks source link

Default values for "Global search" on "history" page #42

Open okt-yurijp opened 4 months ago

okt-yurijp commented 4 months ago

I think that there should be some default value on "Global search" page. From my usual search queries:

  1. "Not compromised" is on, "compromised" is off
  2. Result: "Unexpected" is ON, all others are off
  3. Obtained results: all is ON
okt-kostik commented 4 months ago

The only pending question for me is if we should include Unexpected-only by default.

No. 1 - by default all searches should exclude compromised

No. 3 - I don't understand what you mean

ol-damirm commented 4 months ago

From my point of view, it would be better to use the default result obtained when clicking on the "Reset verdicts section" button.

okt-kostik commented 4 months ago

@ol-damirm you mean fro No3?

ol-damirm commented 4 months ago

Yes, for No3

okt-kostik commented 4 months ago

I would recommend 1, 3 - yes. 2 - no