ts4nfdi / terminology-service-suite

The Terminology Service Suite project is a collection of interactive widgets designed to ease the integration of terminology service functions into third-party applications.
https://ts4nfdi.github.io/terminology-service-suite/comp/latest/
MIT License
16 stars 2 forks source link

Metadata Widget Enhancement and issues #108

Open Pooya-Oladazimi opened 4 months ago

Pooya-Oladazimi commented 4 months ago

Some enhancement suggestions for the metadata widget

https://ts4nfdi.github.io/terminology-service-suite/comp/latest/?path=/docs/react_metadatawidget--docs

Issues: The doc seems to be not correct. It looks like a search doc. Term fetching in OLS does not have these options: Screenshot from 2024-07-10 10-40-24

Types options have strange values (empty and invalid string) Screenshot from 2024-07-10 10-42-42

VincentKneip commented 2 months ago

I agree that the entity label should be bold and moved over the iri. The breadcrumb should stay on top in my opinion, similar to the appearance on EBI-OLS: https://www.ebi.ac.uk/ols4/ontologies/hp/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FHP_0000819

Regarding your question: If the entityType is unknown, the empty string option should be active on the entityType property. This has the same effect as passing undefined to the property, and leads to the widget figuring the correct value of entityType out by itself.

The value INVALID STRING was introduced for testing purposes on incorrect input values. When selected, an error is thrown on the console: grafik

You're right with the docs for the parameter property. Currently, all widgets having the parameter property incorrectly have a doc for search parameters. This has to be corrected for all widgets not using the search endpoint.