IriWidget: flexible copy button needed

ts4nfdi / terminology-service-suite

The Terminology Service Suite project is a collection of interactive widgets designed to ease the integration of terminology service functions into third-party applications.

https://ts4nfdi.github.io/terminology-service-suite/comp/latest/

MIT License

16 stars 2 forks source link

IriWidget: flexible copy button needed #154

Closed jusa3 closed 1 week ago

jusa3 commented 1 month ago

Need flexible copy button (on the left or on the right side of the text).

I see two options:

change the boolean type of copyButton to string or to "left" | "right" | "none" -> would be a breaking change
add another parameter such as copyButtonPosition -> would be a new feature

What do you think @rombaum @Pooya-Oladazimi ?

Pooya-Oladazimi commented 1 month ago

@jusa3

I prefer the new feature (second).

Pooya-Oladazimi commented 1 week ago

@jusa3

I have some confusion about this. Which widget we are talking about? The screenshot does not look like the Title widget. I assume it is the iri widget.

jusa3 commented 1 week ago

You're right, sorry. The screenshot is from the Terminology Service that uses the Iri Widget.

Pooya-Oladazimi commented 1 week ago

@jusa3

Thanks. I changed my mind and went with the first approach to avoid introducing a new input parameter.