search

ts4nfdi / terminology-service-suite

The Terminology Service Suite project is a collection of interactive widgets designed to ease the integration of terminology service functions into third-party applications.
https://ts4nfdi.github.io/terminology-service-suite/comp/latest/
MIT License
16 stars 2 forks source link

GraphViewWidget: Is parameter useLegacy necessary? #160

Closed VincentKneip closed 4 days ago

VincentKneip commented 2 weeks ago

The GraphViewWidget contains a useLegacy parameter, but it doesn't seem to be used. Should the parameter be removed?

@Pooya-Oladazimi

Pooya-Oladazimi commented 2 weeks ago

@VincentKneip

The parameter is currently not used since ols4 v2 does not provide any graph endpoint and the EBI is still using ols3 (ols4 v1). I was not sure that this would be the case in the future so I kept this option open. But you are right, we can remove it from the story inputs at least.

VincentKneip commented 2 weeks ago

All right. I will create a branch addressing a couple of minor issues soon, and deal with this issue there.

VincentKneip commented 4 days ago

Merged with #162