search

ts4nfdi / terminology-service-suite

The SemLookP Widgets project is a collection of interactive widgets designed to ease the integration of terminology service functions into third-party applications.
https://ts4nfdi.github.io/terminology-service-suite/comp/latest/
MIT License
12 stars 2 forks source link

🐎 ci(Docker): Dockerization #92

Closed Pooya-Oladazimi closed 1 month ago

Pooya-Oladazimi commented 1 month ago

Provide a dockerfile for the storybook.

Pooya-Oladazimi commented 1 month ago

Nice! It may be useful to add the npm run storybook for the composed storybook.

They are provided in docker_entry.sh I used this command in the docker CMD instruction, but it did not work. the app was not accessible via ports 6006 and 6007. So I ran both of them separately in the entry script.

In ReadMe:

The React and HTML components can be combined in one Storybook using npm run storybook. Notice that, for this to work, the React Storybook has to be running at http://localhost:6006 and the HTML Storybook at http://localhost:6007.

jusa3 commented 1 month ago

I mean in addition (see comments).

Pooya-Oladazimi commented 1 month ago

I mean in addition (see comments).

Ah ok, thanks. I got it wrong. I though when you run the compose mode you automatically have the html and react on ports 6006 and 6007.

jusa3 commented 2 weeks ago

:tada: This PR is included in version 2.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: