search

tsaad-dev / te

IETF TE Tunnels YANG models
15 stars 19 forks source link

Simplify unions with overlapping types #288

Open italobusi opened 1 month ago

italobusi commented 1 month ago

union of union types (e.g., te-gen-node-id) includes overlapping types (e.g., inet:ip-address vs. inet:ipv6-address-no-zone): consider simplifying.

italobusi commented 1 month ago

I think this comment applies only to typedef te-gen-node-id .

We can consider removing the typedef te-gen-node-id since it cannot be used alone and moving the union within the grouping te-generic-node-id with the description that the union is disambiguated by the leaf type.

To check that the typedef te-gen-node-id is not used in other models.

italobusi commented 1 day ago

2024-09-06 TE Call

Agreed resolution as above: https://github.com/tsaad-dev/te/issues/288#issuecomment-2243656151

Confirmed that the typedef te-gen-node-id is not used in other models