search

tsaglam / Carcassonne

A digital version of the board game Carcassonne, implemented in Java. This desktop computer game supports up to five players at the same time (shared-screen multiplayer mode).
Eclipse Public License 2.0
96 stars 16 forks source link

Nonclickable UI on nonstandard TileType Size #5

Closed sanoy1997 closed 2 years ago

sanoy1997 commented 2 years ago

grafik if the number of different tile types is changed it is possible that the ui doesnt allow the user to click the button to accept a new configuration, as it is not visible on screen. This currently only applies to people who are fumbling around in the code, but based on comments i assume it should be possible later for users to add custom tiles. In that situation the UI should always be clickable

tsaglam commented 2 years ago

This is not a bug in the UI, that is just an effect of not updating the layout of the view when adding more tiles. Just adapt the corresponding UI layout constants in the class: https://github.com/tsaglam/Carcassonne/blob/7c0a0f83a5451618745ab300ae5a372efbba3541/src/main/java/carcassonne/view/tertiary/TileDistributionView.java#L39-L40

sanoy1997 commented 2 years ago

oh nice, i missed them somehow grafik now i can play with the base game

tsaglam commented 2 years ago

Closed, as updating the corresponding UI layout's dimensions is required when adding more tiles.