search

tsaikd / gogstash

Logstash like, written in golang
MIT License
644 stars 106 forks source link

Updates to Elastic #145

Closed helgeolav closed 3 years ago

helgeolav commented 3 years ago

This is an update to #143 where I also added the username/auth to elasticv5 and also added support for NewSimpleClient as mentioned in #144. NewSimpleClient solves a few connectivity issues with some installations. Read more about it here.

tsaikd commented 3 years ago

Please reorganize your commits and rebase to master.

helgeolav commented 3 years ago

Hi

Now I am a bit lost. I have tried to rebase but I don't make anything happen. Can you tell in more detail what I need to do and how?

It seems it could be easier to just delete my fork, do a new fork and then apply the changes. But I have read that it is a bad practice.

tsaikd commented 3 years ago

git rebase is a little bit advanced skill, and it's helpful when you are cleaning the dirty history when developing. If you are a mac user, there is an excellent tool GitUp makes git rebase easier. But you should know exactly what it does for rebasing to avoid any disasters.