search

tsaikd / gogstash

Logstash like, written in golang
MIT License
644 stars 106 forks source link

Implement gelf output #185

Closed mderasse closed 2 years ago

mderasse commented 2 years ago

That implementation allow direct output to Graylog infrastructure.

Multiple implementation of gelf_writer can be found over github. Mostly the one part of that PR is a classical version with a few adaptation to allow configuration of compression / chunkSize, ...

tsaikd commented 2 years ago

Please check https://github.com/tsaikd/gogstash/runs/4974337609?check_suite_focus=true for lint issue.

helgeolav commented 2 years ago

Will it be possible to add some kind of backpressure control on this output? This is a way to ask the input to stop receiving data in case of delivery issues. Look at #182 where I implemented this for another output. I can also help you with this if it is not clear how to do it.

Here is a guide on how to do it: https://github.com/tsaikd/gogstash/tree/master/config/queue

mderasse commented 2 years ago

Thank you for your review and comment

I will take a look at those this weekend, I should also probably update the ReadMe and the documentation regarding the configuration of the GELF output.

mderasse commented 2 years ago

Lint issue fixed (sorry about that ..., i should have check) Queue implemented, one potential issue with the queue is that if one of the host fail (and not the 1st one of the list), we might resend the message.

tsaikd commented 2 years ago

The interface of the queue was changed, so you need to fix for it.

mderasse commented 2 years ago

Thank you :)