Resolve environment variables on elastic URLs

tsaikd / gogstash

Logstash like, written in golang

MIT License

644 stars 106 forks source link

Resolve environment variables on elastic URLs #84

Closed horacimacias closed 5 years ago

horacimacias commented 5 years ago

This allows configuration such as:

url: ["https://%{LOGSTASH_ES_USERNAME}:%{LOGSTASH_ES_PASSWORD}@elastic-service:9200"]

Perhaps this "resolve environment properties in config values" should be done more generically, for all configs.

tsaikd commented 5 years ago

Can you add an unit test?

tsaikd commented 5 years ago

Can you rebase to master for checking CI state?

horacimacias commented 5 years ago

Let me try with a new branch

tsaikd commented 5 years ago

@horacimacias In fact, it's better to use git rebase instead of creating a new PR. A new PR will lose all discussion. If you do not familiar with git command, you'd better to learn more about it. For cooperation and for career.

horacimacias commented 5 years ago

sorry I didn't think of the history/discussion being lost. If you have any good resources to read on rebase/squash please let me know and I'll get up to speed.