feat(actions): Add open_in_mini_files action

tsakirist / telescope-lazy.nvim

Telescope extension that provides handy functionality about plugins installed via lazy.nvim

MIT License

111 stars 2 forks source link

feat(actions): Add open_in_mini_files action #10

Closed wimmstr closed 4 months ago

wimmstr commented 4 months ago

Provides an alternative to open_in_filebrowser()

I guess it does not handle setting mini.files as dependency. I could add a line regarding this in the documentation if you want.

I hope this is ok, as this is my first PR. I just added an alternative function to open files with mini files.

Thanks for this plugin!

kind regards

tsakirist commented 4 months ago

Provides an alternative to open_in_filebrowser()

I guess it does not handle setting mini.files as dependency. I could add a line regarding this in the documentation if you want.

I hope this is ok, as this is my first PR. I just added an alternative function to open files with mini files.

Thanks for this plugin!

kind regards

Thanks for the PR.

Please make the necessary changes:

Extend config.lua with the keymap, add it below open_in_file_browser
Extend README.md with the optional dependency

wimmstr commented 4 months ago

Added the necessary changes.

Decided on M-f for the Keybinding. Can change it to whatever you prefer. I also added the keymapping in the two places of the readme where keymappings are shown (default config, and keymapping table).

kind regards!

tsakirist commented 4 months ago

Sorry for the long delay, I was on vacation!

The PR looks good, but after considering this functionality, I've decided to maintain the focus of this plugin solely on telescope, as its name implies (otherwise, I'd have to change the plugin name as well). Incorporating non-telescope plugins for some actions falls outside its intended scope.

I’ll close this for now. Sorry for any inconvenience.

wimmstr commented 4 months ago

No problem whatsoever!