search

tsamsonov / grwat

R package for hydrograph separation and analysis
https://tsamsonov.github.io/grwat/
Other
7 stars 5 forks source link

Wrong formula for Lyne Hollick method #13

Closed Kaye-HQ closed 1 year ago

Kaye-HQ commented 1 year ago

The current formula you using for Lyne Hollick method seems to be quick flow, rather than baseflow. see Lyne Hollick,1979,Stochastic Time-Variable Rainfall-Runoff Modeling image

Kaye-HQ commented 1 year ago

image

tsamsonov commented 1 year ago

Hi @Kaye-HQ , the issue is actually with function name, not with the formula. A you can see in get_baseflow_recursive function here the value returned by baseflow_lyne is interpreted as a quick flow, i.e. as you expected. Therefore gr_baseflow R interface returns correct value of the baseflow. I'll probably have to fix the function name in the next release of the package.

Kaye-HQ commented 1 year ago

All right, Thanks:)