tsangiotis / elot-743_translator

A Python script to translate Greek Names to English according to ELOT-743
5 stars 0 forks source link

Special cases are ignored #1

Open firew4lker opened 1 year ago

firew4lker commented 1 year ago

The script doesn't follow the standard correctly. There are some special cases that it ignores. For example the name "ΜΠΑΜΠΗΣ" should be translated as "BAMPIS" not as "MPAMPIS". "ΜΠ" on the beginning or the end of a word is converted to "Β".

tsangiotis commented 1 year ago

Hello,

This is an unmaintained repo for whomever finds it useful.

There is a good implementation in ruby by @agorf where special cases are handled correctly:

https://github.com/agorf/greeklish_iso843/blob/master/lib/greeklish_iso843/greek_text.rb

While I am not interested right now to fix this library, I would review and merge a pull request implementing the above logic in python.