tsantalis / RefactoringMiner

MIT License
375 stars 140 forks source link

Missing statement mapping #312

Closed pedramnoori closed 1 year ago

pedramnoori commented 1 year ago

Problem

Missing a statement mapping within an Extract Method refactoring

Commit

Here

File

AbstractModule.java

Extract Method case

Extract Method protected renameModels(oldName String, newName String) : void extracted from public rename(newName String) : void in class jetbrains.mps.project.AbstractModule


Problem description

Within the bodyMapper of the aforementioned refactoring, there is one statement in the nonMappedInnerNodesT1 and one in the nonMappedInnerNodesT2, which have to be mapped together. The two statements are exact the same after argumentization.

Statement from nonMappedInnerNodesT1:

Statement from nonMappedInnerNodesT2:

-if(!m.getModelName().startsWith(oldName + ".")); Line 653 in the child commit

tsantalis commented 1 year ago

Screenshot from 2023-01-02 19-37-10