search

tsantalis / RefactoringMiner

MIT License
372 stars 138 forks source link

Inline variable can’t be detected in some cases #678

Closed simpt5 closed 8 months ago

simpt5 commented 8 months ago

Tested tools and version:

Refactoring Aware Commit Review Chrome Extension (Version: 2.0.4). RefactoringMiner (Version 3.0.4) maven dependency.

Description:

During the usage of RefactoringMiner, I found a few inline variable refactoring cases that can’t be detected. Do you have any idea why this happens and how to resolve this problem?

Commit URL: https://github.com/discoStar711/job-finder/pull/10/commits/4559aa19ca2228a0ebb7242636751c5be4ba42e3

The following inline variable refactoring in the above commit can’t be detected.

image image

The same situation also happens in the following commit: https://github.com/RefactoringGuru/design-patterns-java/pull/15/commits/74514fe2180a00990516d9c47096553f92f86989

The inline variable refactoring following can’t be detected too:

image

tsantalis commented 8 months ago

Related to issue #154

tsantalis commented 8 months ago

@simpt5 Thank you for reporting all these issues. We greatly appreciate this. This issue has been fixed. The Inline Variable refactorings are now detected in both commits.