search

tsantalis / RefactoringMiner

MIT License
358 stars 137 forks source link

Proper handling of "default" #746

Closed koppor closed 3 months ago

koppor commented 3 months ago

I got another "interesting" pull request: https://github.com/JabRef/jabref/pull/11282.

I think, RefactoringMiner does not properly handle "default". Without any change in the letters, it is marked as removed and added:

image

Side note (not related to the issue itself, but to the linked pull request): In general, my wish is "endless scrolling" and not only synchronized scrolling as requested at https://github.com/tsantalis/RefactoringMiner/issues/672

tsantalis commented 3 months ago

@koppor Thank you for reporting the issue.

@pouryafard75 It seems we do not process the default keyword.

tsantalis commented 3 months ago

@koppor We are currently working on the feature to hide the unchanged parts of the code, similar to GitHub.

The endless scrolling feature will be the next one to implement. For the moment, we added two buttons Prev and Next to go directly to the next diff, without going back to the main page listing all diffs.

tsantalis commented 3 months ago

@koppor

We also improved the diff of formatting changes in Javadoc.

image