DOM-objects without an `style`-attribute can now be rendered

tsayen / dom-to-image

Generates an image from a DOM node using HTML5 canvas

Other

10.32k stars 1.68k forks source link

DOM-objects without an `style`-attribute can now be rendered #184

Closed Syndesi closed 9 months ago

Syndesi commented 6 years ago

This resolves #182 . Btw, your current tests are sometimes failing, but this new commit doesn't add any new failures :)

pacproduct commented 6 years ago

@Syndesi : Made a very similar PullRequest that includes a bit more safeguarding. Can't be sure all of them are necessary...

See https://github.com/tsayen/dom-to-image/pull/246

Syndesi commented 6 years ago

@pacproduct Sry for the late reply, but I moved and had no internet until know. Your pull request is indeed better than my solution and therefore I'll close this one. Maybe @tsayen can merge it in time :)

tsayen commented 5 years ago

Hi, thanks for contributing! Indeed, you're right about the tests. They fail on my local machine as well, that one with the text node. Well, I can sort it out later. Your solution looks fine to me, as it doesn't introduce new regression test failures, although it would be nice to add a test for that particular case. Anyway, if you reopen this request, I can merge it.

ProfessorX737 commented 4 years ago

Please merge this change into master. I cannot render image with math without it

michaeljelly commented 2 years ago

@tsayen any chance this can be merged now?

Syndesi commented 9 months ago

Permanently closed as there is no activity by the repository owner anymore.