Attempt at working around elements with no style property.

tsayen / dom-to-image

Generates an image from a DOM node using HTML5 canvas

Other

10.28k stars 1.68k forks source link

Attempt at working around elements with no style property. #246

Closed pacproduct closed 5 years ago

pacproduct commented 5 years ago

Very similar to what's in issue #182.

The attempt here is to ensure elements with no style property do not crash the conversion.

pacproduct commented 5 years ago

Very similar to what has been done in PullRequest https://github.com/tsayen/dom-to-image/pull/184/

tsayen commented 5 years ago

Hi, thanks for contributing! Unfortunately this introduces some test failures. I would happily merge this or now closed #184 whoever reopens/fixes tests first :)

pacproduct commented 5 years ago

@tsayen: Indeed. Not sure how to solve this, I do not have a good enough understanding of this library. Maybe better to merge @Syndesi's merge request then.