search

tsayen / dom-to-image

Generates an image from a DOM node using HTML5 canvas
Other
10.28k stars 1.68k forks source link

Current project status #278

Closed DanielRuf closed 3 years ago

DanielRuf commented 5 years ago

Hi, what is the current status of this project? Is it still maintained?

So far I see no progress since https://github.com/tsayen/dom-to-image/issues/187

IDisposable commented 5 years ago

I have a fork/rename going and am planning on pulling some merges in...

IDisposable commented 5 years ago

https://github.com/1904labs/dom-to-image-more is the GitHub, the https://www.npmjs.com/package/dom-to-image-more is the package. Now entertaining suggestions for what to merge in first :)

AdamZaczek commented 5 years ago

@IDisposable Great! I'll give it a try

Venryx commented 5 years ago

Here are the alternatives to dom-to-image I've found that are still being maintained (at least somewhat): 1) https://github.com/cburgmer/rasterizeHTML.js -- It's based on the same approach as this library uses, except it's more actively maintained. 2) https://github.com/niklasvh/html2canvas -- Seems to use a different approach that is lower-level; in any case it has a lot more code files. It appeared to work fine when I used it, however only has minor updates/maintenance being made.

EDIT: @IDisposable's dom-to-image fork above is a third option:

3) https://github.com/1904labs/dom-to-image-more

And here is a fourth one: (also a fork of dom-to-image)

4) https://github.com/bubkoo/html-to-image

IDisposable commented 5 years ago

I also have a fork and will merge and maintain at https://github.com/1904labs/dom-to-image-more with NPM at https://www.npmjs.com/package/dom-to-image-more

Venryx commented 5 years ago

@IDisposable Okay, good to hear you'll be maintaining your fork as well. :)

signalwerk commented 5 years ago

@tsayen this is a great project but it's slowly dying because there is no maintainer in place. If you could give one or two active people maintainer-status to this repository this would really benefit the whole project. It's always hard to let the children walk on their own feet but I guess the community would highly appreciate it.

DanielRuf commented 5 years ago

@tsayen this is a great project but it's slowly dying because there is no maintainer in place. If you could give one or two active people maintainer-status to this repository this would really benefit the whole project. It's always hard to let the children walk on their own feet but I guess the community would highly appreciate it.

The best in the longterm would be to move it to an org.

tsayen commented 5 years ago

Thanks for the heads up.

I would be very hesitant to share or transfer maintainer rights to this project, as I'm aware of security risks this brings to the users. I don't completely reject the idea though.

I'm aware of the forks and I see nothing wrong with people making or using them, as long as it's compatible with the license. Looks like at least one fork at https://github.com/bubkoo/html-to-image is breaking the license terms.

Let me think about what to do with this repository. I'll get back to you guys within a month. It might be I'll find some time to clean up here.

tsayen commented 5 years ago

I have a question to people interested in this project going on - what is your use case/platform? What is the biggest issue (a link to existing issue would be fine) you want fixed?

ghost commented 5 years ago

angular 7 / Chrome Safari, I use this mainly for printing svg, that i embed with jspdf. Just stumble on mat-icon not rendering properly.

ghost commented 5 years ago

sample https://stackblitz.com/edit/angular-dom2image-j5m93p

signalwerk commented 5 years ago

@tsayen Thank you for your answer. Are you aware of the fact that you can setup github so that a pull-request needs some reviewers before they can get merged. Thats usually how projects like that work to avoid security-issues. If you have a PR that is reviewed from 2–3 people it gets merged.

I completely understand that it's nice to keep the control but please consider bringing the project to a more sustainable form.

My usecase: carbon uses dom-to-image and I would like to work on the font-subsetting to get smaller SVG's