search

tsayen / dom-to-image

Generates an image from a DOM node using HTML5 canvas
Other
10.34k stars 1.68k forks source link

Presence of GNU Licensed files #311

Open suzann007 opened 5 years ago

suzann007 commented 5 years ago

Presence of GNU Licensed files

Some of the files in this module seem to be licensed under GNU General Public License. Hence, we are unable to use this module for our proprietary software. Is there a workaround for this or are there any alternatives?

scottdickerson commented 4 years ago

same problem here for me thinking about using this library instead: https://html2canvas.hertzen.com/

scottdickerson commented 4 years ago

@Abdullah0991 did you ever find a solution?

Abdullah0991 commented 4 years ago

@scottdickerson solution for what?

scottdickerson commented 4 years ago

I put in this PR to fix the GPL libraries (since they were only being used during test time and not at runtime). @tsayen is it possible for you to review?

https://github.com/tsayen/dom-to-image/pull/313

tsayen commented 4 years ago

Hi, which exactly GNU licensed files are we talking about? This lib is not redistributing anything as far as I know.

scottdickerson commented 4 years ago

@tsayen take a look at the PR, there are GPL files inside the bower_components directory (which are only used for the testcases) I've rewritten the test suite to run off the package.json dependencies.

jlczuk commented 2 years ago

Does bower_components have to be included in the default npm package? It's presence is problematic because for me, dom-to-image is in my production dependency tree. As a result, the presence of jquery triggers false reports of vulnerabilities in my project just because it is there. I don't see bower_components as being a dependency of the dom-to-image.min.js artifact that is actually being used in the projects that are in my dependencies.

It would be ideal if you could remove it from the distributed package entirely so that NPM doesn't load it. If you are actually using Bower yourself, for your own build processing, I would contend you should not ship the bower_components directory anymore than you would snip node_modules.