search

tsayen / dom-to-image

Generates an image from a DOM node using HTML5 canvas
Other
10.21k stars 1.68k forks source link

Usage of ocrad-bower #403

Open Domuska opened 2 years ago

Domuska commented 2 years ago

Use case: description, code

The library is using the ocrad-bower library (I'm presuming from here https://github.com/polarity/ocrad-bower), which is licensed under GPL-3.0. This (to my understanding) could be interpreted so that any larger works using this software would need to be licensed under the same license, which is a no-no for a commercial piece of software I'm working on.

I tried to trawl through the library's source code, but couldn't immediately spot if that OCR library is used somewhere, besides what I'm assuming is in the test-lib.

Is the dependency still in use in this library? Could it be removed to prevent the issue with the GPL-3.0? Is the ocrad-bower dependency included in the minified .js file under dist folder?

Expected behavior

-

Actual behavior (stack traces, console logs etc)

-

Library version

2.6.0

Browsers

skcele commented 2 years ago

Wanted to follow up on this. I use dom-to-image in a commercial software project and need to find an alternative if this is not resolved. Thanks!

karsten-klein commented 2 years ago

It seems that ocrad was replaced by tesseract in commit 6f43ce706c06869f3380e39c656e6b61e386d19b 5 years ago, but the dependency in bower_components was never replaced.

One could argue that the current available version does not create a larger work, because it is not really integrated. However it would just be great if one of the project owners could simply remove the obsolete ocrad component.

Furthermore, tesseract (test-lib/tesseract-1.0.10.js) is not attributed correctly either (Apache License 2.0). Generally, I would argue that this module needs some overall licensing/attribution rework. The other components in bower_components are not correctly represented/documented either.