tsbkelly / Streamdeck-Midibutton

MIT License
13 stars 0 forks source link

Lost MIDI Note values in Stream Deck MIDButton #4

Closed nonchai closed 3 years ago

nonchai commented 3 years ago

[Uploading midibuttonlogs.zip…]()

nonchai commented 3 years ago

midibuttonlogs.zip

tsbkelly commented 3 years ago

Hi,

That looks like it's all behaving correctly. Can you try manually setting some of the parameters, closing the Stream Deck application, reopening and then checking that the parameters are retained?

tsbkelly commented 3 years ago

I don't think this is a Catalina/Big Sur issue - I rewrote the plugin to be a lot more efficient, but as part of that I had to change the internal architecture. There was a bug that I missed, and it looks like it's wiped settings in some (all?) instances. If the plugin is working as you expect now you can either recreate your settings, or you can download the previous version (you should be able to access it here and run on the old version. I'd advise recreating, though - every time I update the plugin in the future you'll have to re-download the old version.

nonchai commented 3 years ago

Ok

ive quite SD and re launched and then ive re-entered a few note values into midi buttons .

Result: the values get saved and restored if i've tabbed or clicked into another field , however i notice that if after entering a note value I simply click onto the next button to enter a value in there - the changes do not get saved.

Dan


From: tsbkelly notifications@github.com Sent: 21 December 2020 14:18 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Hi,

That looks like it's all behaving correctly. Can you try manually setting some of the parameters, closing the Stream Deck application, reopening and then checking that the parameters are retained?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-748996302, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSD6D4LQLH2A4EGYNF3SV5KLFANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Hi Dan,

I think that's a Stream Deck thing, rather than a Midi Button thing. There might be a way of rewriting the PI code so that the value is saved instantly, though. Is the plugin itself behaving properly otherwise?

Cheers

nonchai commented 3 years ago

Can you let me know when the above bug has been fixed and then - once I have a modified MIDI button plugin installed in SD I will begin re-entering all the MIDI note values again as you suggest - in your latest release ( beta or not )

I'm afraid I have so many midi buttons for all my instruments and articulations that its jus quicker to enter a note number in a field and then click on the next SD button to edit midi in that one, rather than have to tab or click onto another field in MIDI button simply to trigger some field-changed event in the MIDI button code.

regards

Nonchai

and Merry Xmas!

nonchai commented 3 years ago

Isn't there some kind of SD "button focus changed" event or callback you can trap?

nonchai commented 3 years ago

if not this is definitely a failing/bug in the SD API that needs to be addressed by the Elgato team.

And to me -seems quite a serious flaw.

tsbkelly commented 3 years ago

Try this - you can beta-test it. It's not the recommended way of changing events in the PI, but if it works for you I'll update it on the store.

nonchai commented 3 years ago

thanks.

where do i put the file?

( or is it a double click install type thing? )

Nonchai


From: tsbkelly notifications@github.com Sent: 21 December 2020 16:03 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Try thishttps://www.dropbox.com/s/l703jsbsw7iza4u/co.uk.clarionmusic.midibutton.streamDeckPlugin?dl=0 - you can beta-test it. It's not the recommended way of changing events in the PI, but if it works for you I'll update it on the store.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-749049780, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSCMHUHULMR4L4V4BU3SV5WWJANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Double-click and it should install automatically

nonchai commented 3 years ago

thanks

I've now installed and checked this on both my Catalina mac mini and Big Sur macbook pro and all seems good.

The bugfix appears to work.

Have a great xmas

Dan


From: tsbkelly notifications@github.com Sent: 21 December 2020 16:22 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Double-click and it should install automatically

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-749058559, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSCL5Q6I4MP3Z6IZC43SV5Y3TANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Thanks for letting me know. Before you rebuild your rig could you try another test for me, please? Could you reinstall the version from the Stream Deck store (you may have to uninstall and then reinstall), adjust a bunch of values, and then reinstall (by double-clicking again) the version I've sent you? Hopefully that will confirm that this latest upgrade won't wipe your (and other peoples') settings.

Have a great Christmas.

nonchai commented 3 years ago

ok

but probs wont be able to do this until tomorrow or weds

nonchai


From: tsbkelly notifications@github.com Sent: 21 December 2020 18:28 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Thanks for letting me know. Before you rebuild your rig could you try another test for me, please? Could you reinstall the version from the Stream Deck store (you may have to uninstall and then reinstall), adjust a bunch of values, and then reinstall (by double-clicking again) the version I've sent you? Hopefully that will confirm that this latest upgrade won't wipe your (and other peoples') settings.

Have a great Christmas.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-749125702, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSAYLHIQTRS3PEHBO63SV6HUHANCNFSM4VEIO3GQ.

nonchai commented 3 years ago

Hi,

so ive reinstalled both latest streamdeck AND uninstalled reinstalled the MIDI plugin and it seems ok.

Dan


From: tsbkelly notifications@github.com Sent: 21 December 2020 18:28 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Thanks for letting me know. Before you rebuild your rig could you try another test for me, please? Could you reinstall the version from the Stream Deck store (you may have to uninstall and then reinstall), adjust a bunch of values, and then reinstall (by double-clicking again) the version I've sent you? Hopefully that will confirm that this latest upgrade won't wipe your (and other peoples') settings.

Have a great Christmas.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-749125702, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSAYLHIQTRS3PEHBO63SV6HUHANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Glad to hear it works. I'll push an update once the Elgato guys are back at work.

nonchai commented 3 years ago

Hi again,

Can you tell me which version number I'm to expect?.

I'm getting 1.07

i'm just considering updating the Big Sur macbook here to sync all the settings.

Ive downloaded and installed latest streamdeck and made sure to delete the MIDIBUttin that comes with the SD release and downloaded your "RELEASE" github plugin and double clicked on it to re-add the plugin,

By the way thanks so much for creating this plugin and have yourself and your family a happy new year.

Dan


From: tsbkelly notifications@github.com Sent: 21 December 2020 14:22 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

I don't think this is a Catalina/Big Sur issue - I rewrote the plugin to be a lot more efficient, but as part of that I had to change the internal architecture. There was a bug that I missed, and it looks like it's wiped settings in some (all?) instances. If the plugin is working as you expect now you can either recreate your settings, or you can download the previous version (you should be able to access it herehttps://github.com/tsbkelly/Streamdeck-Midibutton/blob/b980d7fba3dbe9c5bc27e8c8f357a79869a3f0ad/Release/co.uk.clarionmusic.midibutton.streamDeckPlugin and run on the old version. I'd advise recreating, though - every time I update the plugin in the future you'll have to re-download the old version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-748998438, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSE5DDIDQKN5FDYI6JTSV5K27ANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Hi Dan,

Happy new year to you and your family too. The link above (https://github.com/tsbkelly/Streamdeck-Midibutton/blob/b980d7fba3dbe9c5bc27e8c8f357a79869a3f0ad/Release/co.uk.clarionmusic.midibutton.streamDeckPlugin) should download version 1.04, and you should then be able to use the plugin as previously.

Let me know how you get on.

Cheers

nonchai commented 3 years ago

ah so the latest version is 1.07 ?

I'd much rather re-enter all the MIDI data again if 1.07 is a major update and refactor and the way forward.

Dan


From: tsbkelly notifications@github.com Sent: 04 January 2021 10:11 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Hi Dan,

Happy new year to you and your family too. The link above (https://github.com/tsbkelly/Streamdeck-Midibutton/blob/b980d7fba3dbe9c5bc27e8c8f357a79869a3f0ad/Release/co.uk.clarionmusic.midibutton.streamDeckPlugin) should download version 1.04, and you should then be able to use the plugin as previously.

Let me know how you get on.

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-753885179, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSHL6RM6QHRORH5OHSDSYGH43ANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Hi Dan,

I'd definitely recommend that as the way forward. The underlying framework of the plugin won't change again unless it absolutely has to, so you shouldn't have this problem again.

Cheers

nonchai commented 3 years ago

Hi again,

i've now re-entered all the settings and backed up - using v 1.07.

All is good but one thing I noticed was that if an existing button has a MIDI Note value that is intended to be 0 - then even though the value by default is zero ( as things were reset ) then it doesnt actually transmit the right MIDI note value (0 or C-1) unless one changes the value to something else and then back again.

Dan


From: tsbkelly notifications@github.com Sent: 05 January 2021 13:09 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Hi Dan,

I'd definitely recommend that as the way forward. The underlying framework of the plugin won't change again unless it absolutely has to, so you shouldn't have this problem again.

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-754625859, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSFMNTQ3RG33W5HR7OLSYMFRRANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Hi Dan,

I'm not sure I understand - value 0 for a MIDI note is note C-2 (Yamaha/Logic notation) and C-1 (Roland notation). The actual note is always the same - it's the lowest possible MIDI note according to the MIDI specification, so the plugin is sending the correct note value, AFAIK. Or do you mean something else?

Cheers

nonchai commented 3 years ago

yes i might have got the wrong note name ( and in any case whether its -1 or -2 tends to depend on the unit concerned in my experience ) but the key point here is that as a number i'm talking about note number 0 - clearly what appears by default. The lowest note possible in the MIDI spec.

And what i found is that even though it displayed 0 , when button pushed it wasnt actualy sending MIDI 0 until one forces the GUI control field to generate a "changed" event ( or callback whatever ) by changing the value to something else... say 666.... and then back to 0. And then it works fine,

I had to do this to many profiles so its worth fixing.

Dan


From: tsbkelly notifications@github.com Sent: 06 January 2021 13:25 To: tsbkelly/Streamdeck-Midibutton Streamdeck-Midibutton@noreply.github.com Cc: nonchai d0stenning@msn.com; Author author@noreply.github.com Subject: Re: [tsbkelly/Streamdeck-Midibutton] Lost MIDI Note values in Stream Deck MIDButton (#4)

Hi Dan,

I'm not sure I understand - value 0 for a MIDI note is note C-2 (Yamaha/Logic notation) and C-1 (Roland notation). The actual note is always the same - it's the lowest possible MIDI note according to the MIDI specification, so the plugin is sending the correct note value, AFAIK. Or do you mean something else?

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tsbkelly/Streamdeck-Midibutton/issues/4#issuecomment-755297177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJCGSD6IGHJZ2VEQ735IRTSYRQD7ANCNFSM4VEIO3GQ.

tsbkelly commented 3 years ago

Ah, I see what you mean - OK, have fixed that. When I hear back from Elgato about the other ongoing issue and fix that I'll push an update.

Cheers