search

tsbonev / nharker

NHaker - an offline writing organization tool
0 stars 0 forks source link

nharker-core: save trashed domain objects with own id #131

Closed tsbonev closed 6 years ago

tsbonev commented 6 years ago

Wrote an interface for every Domain Entity that contains an id and creationDate, thus the trash collector can rely that everything it receives has an id field and can use that for saving. Closes #130.

codecov[bot] commented 6 years ago

Codecov Report

Merging #131 into master will increase coverage by 0.21%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
+ Coverage      96.6%   96.82%   +0.21%     
- Complexity      273      275       +2     
============================================
  Files            32       32              
  Lines           914      914              
  Branches         82       82              
============================================
+ Hits            883      885       +2     
+ Misses            7        5       -2     
  Partials         24       24
Impacted Files Coverage Δ Complexity Δ
.../kotlin/com/tsbonev/nharker/core/TrashCollector.kt 100% <ø> (ø) 0 <0> (ø) :arrow_down:
...ker/adapter/nitrite/NitriteEntityTrashCollector.kt 100% <ø> (ø) 8 <0> (ø) :arrow_down:
.../src/main/kotlin/com/tsbonev/nharker/core/Entry.kt 100% <100%> (+20%) 4 <3> (+1) :arrow_up:
.../main/kotlin/com/tsbonev/nharker/core/Catalogue.kt 100% <100%> (ø) 6 <3> (ø) :arrow_down:
...rc/main/kotlin/com/tsbonev/nharker/core/Article.kt 100% <100%> (+5.88%) 7 <3> (+1) :arrow_up:
...m/tsbonev/nharker/core/helpers/EntityConverters.kt 100% <100%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12fcb32...1a228b3. Read the comment docs.