search

tschak909 / platoterm64

PLATOTerm for the Commodore 64
GNU General Public License v3.0
35 stars 11 forks source link

Bugfix: use screen resolution to scale the area cleared by prefs_clear() #40

Closed rhalkyard closed 4 years ago

rhalkyard commented 4 years ago

prefs_clear() was doing the wrong thing on screen resolutions that weren't 320x200 pixels (i.e. a 192 pixel PLATO screen). This was most obvious in the 640x480 VDC mode on the C128, where prefs_clear() erased a block halfway up the screen, and not the preferences area at all!

Make sure to double-check the constants that I've used for the new actualSize variable in the various platforms' screen.c files. I'm pretty sure I've got them right based on the scaling factors used, but I'm only really familiar with the Commodore platforms here.

greg-king5 commented 4 years ago

Most of this wasn't needed. The code that erases a prompt should use the same scaling method that's used by the code that prints the prompt.

rhalkyard commented 4 years ago

Good point; I’ll revert and just replace this (and the special-cased Apple II code) with a call to ‘screen_block_draw’