tschare / open-video-ads

Automatically exported from code.google.com/p/open-video-ads
0 stars 0 forks source link

Flowplayer - "Pause", "Resume", "Full screen" events are not sent for mid-roll ads #70

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
"Pause", "Resume", "Full screen" events are not sent for mid-roll ads
They are working for pre-roll and post-roll

My setup (they are also not working in 
http://www.bouncingminds.com/plugins/flowplayer/openvideoads/openadstreamer/late
st/exampl
es/rtmp-example07.html):

Original issue reported on code.google.com by paul.sch...@gmail.com on 8 Sep 2009 at 3:09

GoogleCodeExporter commented 8 years ago
In the OpenX JIRA system as 
https://developer.openx.org/jira/browse/OXPL-496

Original comment by paul.sch...@gmail.com on 8 Sep 2009 at 3:09

GoogleCodeExporter commented 8 years ago
Yes, verified - this is a bug. There is an exception being thrown on 
fullscreen, pause and resume in the 
Flowplayer Open Ad Streamer...

A null type exception on Stream.processFullScreenEventForStream

Original comment by paul.sch...@gmail.com on 8 Sep 2009 at 4:46

GoogleCodeExporter commented 8 years ago
This is a critical bug, as when the mid roll is paused, it is impossible to 
replay
again. 

Original comment by matthieu...@gmail.com on 8 Sep 2009 at 6:28

GoogleCodeExporter commented 8 years ago
Fixed for FP 0.2.5 ...

This was a problem because the FP OAS was pulling off the index of the active 
clip from the playlist, but FP 
treats instream and child (mid-roll) clips differently - the playlist returns 
-1, so I needed to track the index of 
the mid-roll and overlay click to video clips differently.

The following code as added:

        private function getActiveStreamIndex():int {
            if(_player.currentClip.isInStream) {
                // we need to treat instream clips differently as "currentIndex" on the playlist is -1
                return (_player.currentClip as ScheduledClip).key;
            }
            return _player.playlist.currentIndex;
        }

The stream index of the active clip is now in the wrapper class (ScheduledClip).

Original comment by paul.sch...@gmail.com on 8 Sep 2009 at 7:08

GoogleCodeExporter commented 8 years ago
I've made the code change to 0.2.5 - want to test it throughly before 
releasing, and I've added some additional 
changes to the framework to detect when these player events relate to overlay 
linear clips so that they are 
forwarded to the right Ad Slot... I need to test all that as well and check the 
Flowplayer OAS mainline and overlay 
events with the change.

Original comment by paul.sch...@gmail.com on 8 Sep 2009 at 7:39

GoogleCodeExporter commented 8 years ago
validated - fixed.

Original comment by paul.sch...@gmail.com on 26 Sep 2009 at 10:04