tschaub / gh-pages

General purpose task for publishing files to a gh-pages branch on GitHub
https://www.npmjs.com/package/gh-pages
MIT License
3.24k stars 190 forks source link

Publish not returning a promise #465

Open achingbrain opened 1 year ago

achingbrain commented 1 year ago

The commit message for https://github.com/tschaub/gh-pages/commit/e1374b331b4a4365c5f266e94a27b01e702adc74 says to always return a promise but I think this block can still cause the publish method to return void and not Promise<void> - it might be simpler to use the async keyword on the function?