search

tschaub / mock-fs

Configurable mock for the fs module
https://npmjs.org/package/mock-fs
Other
911 stars 86 forks source link

Fixing test failures on node 8 #209

Closed AGrzes closed 7 years ago

AGrzes commented 7 years ago

This is still work in progress.

I managed to fix first issue - with stat function - but there is still a lot of tests failing.

AGrzes commented 7 years ago

At the moment 32 tests failed in comparison to initial 48.

AGrzes commented 7 years ago

At the moment 32 tests failed in comparison to initial 48.

AGrzes commented 7 years ago

All test failures resolved. I still do not like the fact that maybeStatCallback is copy-paste of maybeCallback

tschaub commented 7 years ago

Thanks for the work on this @AGrzes!

tschaub commented 7 years ago

I still do not like the fact that maybeStatCallback is copy-paste of maybeCallback

I removed the duplication in 85396c2a98e096439cf961d08adb8f54f111c7e5 (by adding a wrapStatsCallback function).

tschaub commented 7 years ago

Support for Node 8 published in mock-fs@4.4. Thanks @AGrzes for the contribution.