search

tschaub / mock-fs

Configurable mock for the fs module
https://npmjs.org/package/mock-fs
Other
906 stars 85 forks source link

rbinding.readdir can take anywhere from 2 to 4 arguments #251

Closed maxwellgerber closed 6 years ago

maxwellgerber commented 6 years ago

fixes #250

Does not provide support for DirEnt objects that were introduced in 10.10.0 with https://github.com/nodejs/node/commit/c7944a7a7bd92a446ea81d774ccad31e0e7c8a3f But makes fs.readdir and fs.readdirSync work again.

kibertoad commented 6 years ago

@tschaub Could you please take a look at this and release a fixed version when possible? We are blocked by this...

tschaub commented 6 years ago

Thanks @maxwellgerber!

kibertoad commented 6 years ago

@tschaub Any change you could release a new version with a fix :)?