tschellenbach / Django-facebook

Facebook open graph api implementation using the Django web framework in python
http://www.mellowmorning.com/
Other
1.43k stars 543 forks source link

django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? #523

Open amarpreetsaini opened 9 years ago

amarpreetsaini commented 9 years ago

I was using an older version of both django and django_facebook previously. I migrated to django 1.7 and installed latest django_facebook. To setup DB table i did following

Ran python manage.py makemigraitons django_facebook

This generated the migration file with table name django_facebook_opengraphshare.

While the makemigration created table name as django_facebook_opengraphshare, the other code is expecting it to be django_facebook_open_graph_share.

To test the issue i changed the migrations file manually and changed the table name to django_facebook_open_graph_share. With this change i was able to successfully do migrations.

So When and why was this change implemented in table name ? If this is legitimate then why the code in admin.py expecting the older table name ?

vially commented 9 years ago

I haven't tried the latest versions of django or django-facebook but last time I tried I did not face this issue.

512 was only meant to add an empty init.py file to the migrations directory because otherwise the new migrations system found in django 1.7 would not recognize the migrations at all (maybe this has changed in the latest version of django?)

amarpreetsaini commented 9 years ago

My mistake i thought 0001_initial.py was also added by you. But whether you have a table named django_facebook_open_graph_share or django_facebook_opengraphshare.