tschellenbach / Django-facebook

Facebook open graph api implementation using the Django web framework in python

http://www.mellowmorning.com/

Other

1.43k stars 543 forks source link

Login flow broke by a recent commit #593

Open masterchiefag opened 7 years ago

masterchiefag commented 7 years ago

This commit in PR #587 has broken the login flow.

The problematic change is:

(Earlier)

      self._me = me = self.get('me', fields="id,name,email,verified")

(Now)

      self._me = me = self.get('me')

In django_facebook/connect.py line 69: email = facebook_data.get('email', False) email comes out as False here and as a result the user lands to error page saying email field is required. Verified it by reverting this change.

tschellenbach commented 7 years ago

That analysis looks correct to me. I've just pushed a change on master.

About Maintenance & Django-Facebook

Django and Facebook are both rapidly changing at the moment. Meanwhile, I'm caught up in a startup and don't have much spare time. The library needs a good round of testing against the latest python, django and facebook graph API. Contributions are strongly appreciated. Seriously, give github a try, fork and get started :)